Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Java time instances for PostgreSQL #1736

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

guymers
Copy link
Contributor

@guymers guymers commented Aug 29, 2022

Given that the Postgres JDBC driver does not return *WithTimezone types,
change the type when creating meta column and parameter objects. This
allows the Java time instance for OffsetDateTime to be defined as
requiring a column to be a TimestampWithTimezone.

@guymers
Copy link
Contributor Author

guymers commented Aug 29, 2022

Would resolve #1481

Given that the Postgres JDBC driver does not return *WithTimezone types,
change the type when creating meta column and parameter objects. This
allows the Java time instance for `OffsetDateTime` to be defined as
requiring a column to be a `TimestampWithTimezone`.
@guymers guymers force-pushed the postgres-java-time-2 branch from e4900fe to 3ff4289 Compare October 13, 2022 10:27
Copy link
Contributor

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you 👍

@jatcwang jatcwang merged commit df6a210 into typelevel:main Dec 21, 2022
@jatcwang
Copy link
Collaborator

Thanks!

@guymers guymers deleted the postgres-java-time-2 branch December 21, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants