Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withLogHandler method to Transactor #1977

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

sideeffffect
Copy link
Contributor

No description provided.

@mergify mergify bot added the core label Jan 10, 2024
@jatcwang jatcwang added this to the 1.0 milestone Jan 10, 2024
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I am not a maintainer of this repository, I would really appreciate if this change could be accepted. This PR introduces a new capability of injecting log-handlers locally, which was not that easy previously.

I believe it is important because without such a capability it is quite tricky to make log messages having their own unique logger names. So that by default all the log messages usually share the same logger name, which is not always that convenient especially in big projects.

That said, I feel it would not hurt if there was a test added for this feature. E.g. modules/core/src/test/scala/doobie/util/TransactorSuite.scala seems to be a good place for that.

@jatcwang jatcwang merged commit 6dc52d6 into typelevel:main Apr 24, 2024
6 checks passed
@sideeffffect sideeffffect deleted the withLogHandler branch April 25, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants