-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tut in Travis builds (fix #362) #363
Changes from all commits
c5c90b7
1b2d5ef
99008aa
f164939
74e33c1
1d42a29
6e93b95
89ad5c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,9 @@ import scalaz.syntax.monad._ | |
import scalaz.syntax.catchable._ | ||
#-scalaz | ||
#+cats | ||
import doobie.util.catchable._ | ||
#+fs2 | ||
import fs2.interop.cats._ | ||
#-fs2 | ||
import cats.implicits._ | ||
#-cats | ||
|
||
|
@@ -22,7 +24,13 @@ object catchablespec extends Specification { | |
} | ||
|
||
"work on unaliased IConnection" in { | ||
#+scalaz | ||
42.pure[ConnectionIO].map(_ + 1).attempt | ||
#-scalaz | ||
#+cats | ||
// TODO Remove yax (https://github.com/tpolecat/doobie/issues/369) | ||
(42.pure[ConnectionIO].map(_ + 1): ConnectionIO[Int]).attempt | ||
#-cats | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Forgot to ping @tpolecat, is this what you mean? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, perfect. Thanks! |
||
true | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,8 +24,8 @@ import doobie.imports._ | |
import scalaz._, Scalaz._ | ||
#-scalaz | ||
#+cats | ||
import doobie.util.compat.cats.monad._ // todo: make this automatic | ||
import cats._, cats.data._, cats.implicits._ | ||
import fs2.interop.cats._ | ||
#-cats | ||
``` | ||
|
||
|
@@ -120,7 +120,7 @@ program3a.replicateM(5).transact(xa).unsafePerformIO.foreach(println) | |
#-scalaz | ||
#+cats | ||
```tut | ||
program3a.replicateA(5).transact(xa).unsafePerformIO.foreach(println) | ||
Applicative[ConnectionIO].replicateA(5, program3a).transact(xa).unsafePerformIO.foreach(println) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Urgh. |
||
``` | ||
#-cats | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional indirection confuses type inference here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this test as-is and yax it out for cats, then open a separate issue to sort this out. I know Adelbert is pretty focused on it so maybe he'll have some ideas.