Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it easier to work with Optional columns. #479

Merged
merged 1 commit into from
Jan 2, 2021

Conversation

imarios
Copy link
Contributor

@imarios imarios commented Dec 23, 2020

case class X(i: Option[Int], j: Option[String])
val t = TypedDataset.create(Seq( X(Some(1), None), X(None, None), X(Some(10), Some("foo"))))
 t.select(t('i).opt.map(_*2), t('j).opt.map(_.startsWith("fo"))).show().run()
+----+----+
|  _1|  _2|
+----+----+
|   2|null|
|null|null|
|  20|true|
+----+----+

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #479 (5f345a8) into master (854d5b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   96.23%   96.24%           
=======================================
  Files          60       60           
  Lines        1036     1038    +2     
  Branches        7        9    +2     
=======================================
+ Hits          997      999    +2     
  Misses         39       39           
Flag Coverage Δ
2.12.12 96.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dataset/src/main/scala/frameless/TypedColumn.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854d5b6...5f345a8. Read the comment docs.

@imarios imarios merged commit 08a2979 into typelevel:master Jan 2, 2021
@ayoub-benali
Copy link
Contributor

This is a really great improvement, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants