Map encoder with Value class #567

cchantep · 2021-10-05T22:09:16Z

Closes #566

codecov · 2021-10-06T11:48:55Z

Codecov Report

Merging #567 (68a7c97) into master (7b08c31) will decrease coverage by 0.80%.
The diff coverage is 93.63%.

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   96.35%   95.54%   -0.81%     
==========================================
  Files          63       63              
  Lines        1071     1101      +30     
  Branches        9        8       -1     
==========================================
+ Hits         1032     1052      +20     
- Misses         39       49      +10

Flag	Coverage Δ
2.12.15	`95.54% <93.63%> (-0.81%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ataset/src/main/scala/frameless/TypedEncoder.scala	`97.58% <93.24%> (-2.42%)`	⬇️
...taset/src/main/scala/frameless/RecordEncoder.scala	`93.58% <93.93%> (-6.42%)`	⬇️
...t/src/main/scala/frameless/functions/package.scala	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b08c31...68a7c97. Read the comment docs.

cchantep · 2021-10-10T12:43:20Z

dataset/src/main/scala/frameless/RecordEncoder.scala


  /**
   * @tparam F the value class
   * @tparam G the single field of the value class
   * @tparam H the single field of the value class (with guarantee it's not a `Unit` value)
   * @tparam V the inner value type
   */
-  implicit def valueClass[F : IsValueClass, G <: ::[_, HNil], H <: ::[_, HNil], V]
+  implicit def valueClass[F : IsValueClass, G <: ::[_, HNil], H <: ::[_ <: FieldType[_ <: Symbol, _], HNil], K <: Symbol, V, KS <: ::[_ <: Symbol, HNil]]


Also capture keys evidence so it can be used to wrap/unwrap in the map/array/collection encoder of Value class

@cchantep thanks for clarifying it.

cchantep · 2021-10-10T12:43:54Z

dataset/src/main/scala/frameless/TypedEncoder.scala


-  implicit val javaBigDecimalEncoder: TypedEncoder[java.math.BigDecimal] = new TypedEncoder[java.math.BigDecimal] {
-    def nullable: Boolean = false
+      override def toString: String = "bigDecimalEncoder"


Useful when debuging

cchantep · 2021-10-10T12:45:17Z

dataset/src/main/scala/frameless/TypedEncoder.scala

@@ -210,29 +226,39 @@ object TypedEncoder {
      )
  }

-  implicit def arrayEncoder[T: ClassTag](implicit encodeT: TypedEncoder[T]): TypedEncoder[Array[T]] =
+  implicit def arrayEncoder[T: ClassTag](


Refactor to support array of Value class with the typeclass RecordFieldEncoder (rather than the lower TypedEncoder one)

cchantep · 2021-10-10T12:46:04Z

dataset/src/test/scala/frameless/RecordEncoderTests.scala

 }

 import shapeless.{HList, LabelledGeneric}
 import shapeless.test.illTyped

 import org.scalatest.matchers.should.Matchers

-case class UnitsOnly(a: Unit, b: Unit)


cchantep · 2021-10-10T14:27:44Z

@pomadchin This can be reviewed

pomadchin · 2021-10-10T23:33:17Z

@cchantep wow a solid PR; will take some time to look through that in the beginning of the work week.

cchantep · 2021-10-14T18:06:59Z

Is that ok for you @pomadchin ?

pomadchin

Checked it on my project and works nice, thanks for this solid and exciting improvement! This PR adds an additional tests coverage as well.

pomadchin · 2021-10-14T18:21:51Z

dataset/src/main/scala/frameless/RecordEncoder.scala


  /**
   * @tparam F the value class
   * @tparam G the single field of the value class
   * @tparam H the single field of the value class (with guarantee it's not a `Unit` value)
   * @tparam V the inner value type
   */
-  implicit def valueClass[F : IsValueClass, G <: ::[_, HNil], H <: ::[_, HNil], V]
+  implicit def valueClass[F : IsValueClass, G <: ::[_, HNil], H <: ::[_ <: FieldType[_ <: Symbol, _], HNil], K <: Symbol, V, KS <: ::[_ <: Symbol, HNil]]


@cchantep thanks for clarifying it.

pomadchin · 2021-10-14T18:24:05Z

dataset/src/main/scala/frameless/TypedEncoder.scala

@@ -54,15 +55,16 @@ object TypedEncoder {
      Invoke(path, "toString", jvmRepr)
  }

-  implicit val booleanEncoder: TypedEncoder[Boolean] = new TypedEncoder[Boolean] {


I'm a bit confused by the formatting that happened here, makes it harder to read the diff

dataset/src/main/scala/frameless/TypedEncoder.scala

pomadchin · 2021-10-14T18:28:36Z

dataset/src/main/scala/frameless/functions/package.scala

+      i3: Keys.Aux[H, KS],
+      i4: Values.Aux[H, VS],


Do we need these constrains here?

i3: Keys.Aux[H, KS], i4: Values.Aux[H, VS]

Required to call RecordFieldEncoder.valueClass (l80)

pomadchin · 2021-10-14T18:36:06Z

@cchantep sorry that it took so long! I'm also willing to have a look into #571 this week.

cchantep force-pushed the feature/map-valueclass-typedencoder branch from f370ae2 to d947a30 Compare October 6, 2021 11:22

cchantep added 4 commits October 9, 2021 23:13

Refactor Map encoder to support cases such as Value classes

0c4d4d4

Refactor arrayEncoder

e27d74d

Make sure encoder are lazy

4ef3098

Refactor collectionEncoder

fe18ef2

cchantep force-pushed the feature/map-valueclass-typedencoder branch from d947a30 to fe18ef2 Compare October 10, 2021 12:42

cchantep changed the title ~~WIP: Fix #566 - Map encoder with Value class~~ Fix #566 - Map encoder with Value class Oct 10, 2021

cchantep commented Oct 10, 2021

View reviewed changes

Fix MiMa

68a7c97

pomadchin approved these changes Oct 14, 2021

View reviewed changes

cchantep merged commit f25a99c into typelevel:master Oct 15, 2021

cchantep deleted the feature/map-valueclass-typedencoder branch October 15, 2021 09:36

pomadchin added the bug label Oct 18, 2021

pomadchin changed the title ~~Fix #566 - Map encoder with Value class~~ Map encoder with Value class Oct 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Map encoder with Value class #567

Map encoder with Value class #567

cchantep commented Oct 5, 2021 •

edited by pomadchin

Loading

codecov bot commented Oct 6, 2021 •

edited

Loading

cchantep Oct 10, 2021

pomadchin Oct 14, 2021

cchantep Oct 10, 2021

cchantep Oct 10, 2021

cchantep Oct 10, 2021

cchantep commented Oct 10, 2021

pomadchin commented Oct 10, 2021

cchantep commented Oct 14, 2021

pomadchin left a comment

pomadchin Oct 14, 2021

pomadchin Oct 14, 2021

pomadchin Oct 14, 2021

cchantep Oct 14, 2021

pomadchin commented Oct 14, 2021

Map encoder with Value class #567

Map encoder with Value class #567

Conversation

cchantep commented Oct 5, 2021 • edited by pomadchin Loading

codecov bot commented Oct 6, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cchantep commented Oct 10, 2021

pomadchin commented Oct 10, 2021

cchantep commented Oct 14, 2021

pomadchin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pomadchin commented Oct 14, 2021

cchantep commented Oct 5, 2021 •

edited by pomadchin

Loading

codecov bot commented Oct 6, 2021 •

edited

Loading