Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to adapt status runtime exceptions #137

Merged
merged 1 commit into from
Nov 19, 2019
Merged

add ability to adapt status runtime exceptions #137

merged 1 commit into from
Nov 19, 2019

Conversation

ahjohannessen
Copy link
Collaborator

  • add ability for clients to adapt status runtime exceptions
    sent from server side.

@ahjohannessen
add ability to adapt status runtime exceptions
4b23a55 
 - add ability for clients to adapt status runtime exceptions
   sent from server side.
@ahjohannessen ahjohannessen mentioned this pull request Nov 17, 2019
Closed
@ahjohannessen
Copy link
Collaborator Author

@rossabaker @fiadliel Could you please take a look :)

rossabaker
rossabaker approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Seems like we'll need to bump the minor version, too?

@ahjohannessen
Copy link
Collaborator Author

ahjohannessen commented Nov 18, 2019 •
edited
Loading

@rossabaker You mean like 0.6.0 - This should not introduce any breaking change as the code generator inserts a _ => None and apply has errorAdapter: StatusRuntimeException => Option[Exception] = _ => None, so I guess 0.5.6 is fine?

@rossabaker
Copy link
Member

I don't think it breaks source compatibility. I was thinking in terms of binary compatibility.

@rossabaker rossabaker merged commit 39aa700 into typelevel:master Nov 19, 2019
@ahjohannessen ahjohannessen deleted the wip-error-adapter-alt branch November 19, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahjohannessen @rossabaker