Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only rely on grpc-api + prepare for controlling grpc version #168

Merged
merged 1 commit into from
Mar 13, 2020
Merged

only rely on grpc-api + prepare for controlling grpc version #168

merged 1 commit into from
Mar 13, 2020

Conversation

ahjohannessen
Copy link
Collaborator

@ahjohannessen ahjohannessen commented Mar 11, 2020 •
edited
Loading

  • change plugin to use grpc version from build-info
    and use organization from build-info instead in order
    to make it possible to use a different organization
    in build.

  • change dependency on grpc for runtime to only rely
    on grpc-api as grpc-core is not needed.

@fedefernandez fedefernandez mentioned this pull request Mar 11, 2020
Closed
2 tasks
@ahjohannessen
Copy link
Collaborator Author

@rossabaker Do not merge this yet. Forgot that the sbt plugin adds dependencies. I need to align dependencies.

@ahjohannessen ahjohannessen force-pushed the wip-grpc-dependencies branch from 5654354 to cb251cd Compare March 12, 2020 12:45
@ahjohannessen
Copy link
Collaborator Author

@rossabaker Things should be aligned now. scalapb-runtime-grpc brings about grpc-stub and grpc-protobuf. I have added grpc-protobuf explicitly to have it evicted via grpcVersion in BuildInfo.

@ahjohannessen
deps: only rely on grpc-api + prepare for controlling grpc version
95f7fc1 
 - change plugin to use grpc version from build-info
   and use organization from build-info instead in order
   to make it possible to use a different organization
   in build.

 - change dependency on grpc for runtime to only rely
   on grpc-api as grpc-core is not needed.
@ahjohannessen ahjohannessen force-pushed the wip-grpc-dependencies branch from cb251cd to 95f7fc1 Compare March 13, 2020 09:14
@ahjohannessen ahjohannessen changed the title deps: control grpc version + only rely on grpc-api only rely on grpc-api + prepare for controlling grpc version Mar 13, 2020
@ahjohannessen ahjohannessen changed the title only rely on grpc-api + prepare for controlling grpc version only rely on grpc-api + prepare for controlling grpc version Mar 13, 2020
@ahjohannessen
Copy link
Collaborator Author

ahjohannessen commented Mar 13, 2020 •
edited
Loading

@rossabaker I changed the PR to use grpc that scalapb brings about, but prepared code to point to grpc version defined in dependencies via BuildInfo. I updated scalapb earlier to 0.10.2 that brings in latest grpc, 1.28.0, so version of grpc can be changed to use our own variable at a later point if scalapb is lagging to much.

@ahjohannessen ahjohannessen merged commit 592de55 into master Mar 13, 2020
@ahjohannessen ahjohannessen deleted the wip-grpc-dependencies branch March 13, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker Awaiting requested review from rossabaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahjohannessen