New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix server don't sends header that client has sent #492

Merged

ahjohannessen merged 1 commit into typelevel:main from naoh87:fix_send_headers

Jan 30, 2022

Contributor

naoh87 commented Jan 30, 2022 •

edited

Loading

cf. https://github.com/grpc/grpc-java/blob/master/stub/src/main/java/io/grpc/stub/ServerCalls.java#L377
Current behavior may cause vulnerabilities when fs2-grpc is used through gRPC-web or gRPC-JSON transcoder.


          fix server don't sends header that client has sent

9cbc168

Collaborator

ahjohannessen commented Jan 30, 2022

This is indeed an oversight. Looked through corresponding grpc-java code and the behaviour is similar to your changes 👍

ahjohannessen merged commit 20056a5 into typelevel:main

Collaborator

ahjohannessen commented Jan 30, 2022

Released v2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet