Fixed memory leak in Promise#cancellableGet #1027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation of
cancellableGet
had two flaws:force
would register a callback under an internal id, overwriting any previously registered callback for the same idcancel
would simply remove the registration for the idFor example,
cancel *> force
would result in a state where a callback for the force was registered.force *> force *> force
would result in a similar state, where the first two force actions would never be completed.To fix, the internal state has been changed so that we track a list of callbacks associated with each id. Calling
cancellableGet
registers an empty list under that id. Eachforce
adds a new callback to the list, but only if that id is still in the map. Callingcancel
removes the id from the map.