Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream.evalFilter #1619

Merged
merged 14 commits into from
Sep 16, 2019
Merged

Stream.evalFilter #1619

merged 14 commits into from
Sep 16, 2019

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Sep 13, 2019 •
edited
Loading

Reincarnation of #1583.

@mpilquist
Copy link
Member

The tests were failing on the call to s.toList in asserting(_ shouldBe s.toList). The call to s.toList calls unsafeRunSync on an internal IO value that's guaranteed to be synchronous. However, the internals of IO have a bug where a separate IO compilation can confuse the check -- the workaround is here: typelevel/cats-effect#529

@mpilquist mpilquist mentioned this pull request Sep 16, 2019
Closed
@kubukoz
Copy link
Member Author

kubukoz commented Sep 16, 2019

That looks slightly better, thanks. Still getting some weird JS errors...

@mpilquist
Copy link
Member

@kubukoz I got it passing. Ready to merge if you are.

@kubukoz kubukoz marked this pull request as ready for review September 16, 2019 16:51
@kubukoz
Copy link
Member Author

kubukoz commented Sep 16, 2019

Good to go!

@mpilquist mpilquist merged commit 95d59f6 into typelevel:master Sep 16, 2019
@mpilquist mpilquist modified the milestones: 2.0.0, 2.0.1 Sep 21, 2019
@CremboC CremboC mentioned this pull request Sep 24, 2019
Merged
@kubukoz kubukoz mentioned this pull request Dec 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kubukoz @mpilquist