Add readOutputStream combinator in fs2-io
#1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daenyth
force-pushed
the
read-outputstream
branch
from
f91d6fb to
eb13341
Compare
|
@Daenyth Anything left on this one? It's still marked as a draft. |
|
I swear the tests were failing, but it's green now and I haven't changed anything. I have no idea what's up there. |
|
@mpilquist should be good to go now that it's green |
|
About the failing tests, I'll repeat it here so it doesn't get lost: it looks like the first test can deadlock on a single-thread |
mpilquist
reviewed
Oct 14, 2019
|
|
||
| Stream.resource(mkOutput).flatMap { | ||
| case (os, is) => | ||
| val write = f(os) *> Sync[F].delay(os.close()) |
There was a problem hiding this comment.
Use blocker.delay here instead
| ) { (bytes: Array[Byte], chunkSize: Int) => | ||
| Blocker[IO].use { blocker => | ||
| readOutputStream[IO](blocker, chunkSize)( | ||
| (os: OutputStream) => IO(os.write(bytes)) |
There was a problem hiding this comment.
Use blocker.delay[IO] instead (h/t @nigredo-tori)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to finalize the unit tests - I copied what was in my gist with minor adaptations, needs cleaning still
Close #1641