Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting needClientAuth with TLSParameters #1767

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Support setting needClientAuth with TLSParameters #1767

merged 1 commit into from
Jan 29, 2020

Conversation

rossabaker
Copy link
Member

Calling setWantClientAuth clears setNeedClientAuth and vice versa. Since setWantClientAuth is called last, getNeedClientAuth is never true.

Changes so if needClientAuth is true, it is set on SSLParameters, regardless of wantClientAuth. If needClientAuth is false, wantClientAuth wins. The default of both SSLParameters and TLSParameters is that neither is set.

@mpilquist mpilquist self-requested a review January 29, 2020 16:40
@mpilquist mpilquist merged commit f2d5df3 into typelevel:master Jan 29, 2020
@mpilquist mpilquist added this to the 2.2.2 milestone Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

@mpilquist mpilquist mpilquist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rossabaker @mpilquist @ChristopherDavenport