Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust thread names of tcp.SocketGroup's nonBlockingThreadFactory #1862

Merged
merged 1 commit into from
May 8, 2020

Conversation

azolotko
Copy link
Contributor

@azolotko azolotko commented May 5, 2020

Threads produced by the nonBlockingThreadFactory are used in a non-blocking fashion, but their names suggest otherwise. Let's change the prefix to fs2-socket-group-non-blocking to align with the actual usage pattern.

Threads produced by the nonBlockingThreadFactory are used in a non-blocking fashion, but their names suggest otherwise. Let's change the prefix to fs2-socket-group-non-blocking to align with the actual usage pattern.
@mpilquist mpilquist merged commit 4569247 into typelevel:master May 8, 2020
@mpilquist mpilquist added this to the 2.4.0 milestone Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants