TLS handshaking issues with Postgres #1897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1896.
isValid
onSSLSession
. On JDK 1.8.0_192, after the handshake completes with postgres,engine.getSession.isValid
returns false andengine.getSession.getId
returns an empty array. Same program works fine on JDK 11. This was trickingTLSEngine.read
in to thinking it needed to handshake again, ad infinitum. Switched to comparing cipher suite toSSL_NULL_WITH_NULL_NULL
, which is the documented cipher suite prior to handshake completion.socket.read(n)
will return a chunk with <= n bytes, butTLSEngine
was violating that.Most of the diff is just passing
maxBytes
through the various calls.Tested this on both JDK 1.8 and 11 using Rob's sample Postgres client.