Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP, UDP, and TLS networking capabilities #2071

Merged
merged 4 commits into from
Oct 11, 2020

Conversation

mpilquist
Copy link
Member

I don't feel as good about this one as Files[F], but interested in thoughts.

@mpilquist mpilquist changed the base branch from main to develop October 8, 2020 02:28
@SystemFw
Copy link
Collaborator

SystemFw commented Oct 8, 2020

I think the basic idea is solid, especially because we have a passthrough instance so the user can choose to just use Async anyway (we need docs for that). The only thing is that maybe it's a bit too granular? we could have Files[F] and Network[F] (or Sockets[F]), although it's arbitrary any way.

Why don't you feel as good about this one?

@mpilquist
Copy link
Member Author

👍 for Network[F] instead of tcp.Sockets[F], udp.Sockets[F], tls.TLS[F]

Seems kind of odd so directly wrap Async[F] and have no operations on the capability trait. It's okay though.

@SystemFw
Copy link
Collaborator

SystemFw commented Oct 8, 2020

Seems kind of odd so directly wrap Async[F] and have no operations on the capability trait. It's okay though.

mm ok I see

@mpilquist mpilquist merged commit 9d86994 into typelevel:develop Oct 11, 2020
@mpilquist mpilquist deleted the topic/networking-capabilities branch February 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants