-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs2-protocols - pcapng #2740
fs2-protocols - pcapng #2740
Conversation
Looking good! Some high level comments:
|
I think there is. However, I think this functionality should be not in the
What are the options assuming that I want to define common block structure? I think I can put HList-based implementation to |
I think I should look at |
Yeah, scodec uses HLists on Scala 2 and tuples on Scala 3. There's a little bit of trickery to get the same source cross compiling on both: https://github.com/scodec/scodec/blob/7724ae7efed0ea9e32063b56cf81bd3ffeb381f0/shared/src/main/scala/scodec/compat.scala |
a97af5b
to
97b14f3
Compare
@nikiforo Any way I can help get this one over the finish line? |
a54fcb4
to
8d55e61
Compare
No description provided.