Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Stream.fromIterator sync type configurable #2933

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

armanbilge
Copy link
Member

Fixes #2903, which I found new sympathy for while working on #2931.

This allows a third parameter to be passed to Stream.fromIterator indicating whether to use Delay, Blocking, Interruptible, or InterruptibleMany.

Comment on lines +3335 to +3336
def fromBlockingIterator[F[_]]: PartiallyAppliedFromBlockingIterator[F] =
new PartiallyAppliedFromBlockingIterator(blocking = true)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This signature change is binary-compatible because PartiallyAppliedFromBlockingIterator is an AnyVal for Boolean, just like PartiallyAppliedFromIterator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream.fromBlockingIterator is never interruptible
3 participants