Add 'Stream.ToPull.unconsMin', remove 'Stream.ToPull.unconsLimit' ass… #3021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
Stream.ToPull.unconsMin
and changed logic of bothStream.ToPull.unconsN
andStream.chunkMin
to use it.Main motivation: if you working with some 'frames' of size N, sometimes you also can process chunks of M * N size in a batch, right now it is possible only via (afaik)
.chunkMin(N).scan(Chunk.empty)(..).unchunk
. New operation allows this directly on pull.Also I've removed an assertion of
n > 0
onunconsLimit
as all other similar methods (unconsN, chunkMin, chunkM
) to do not fail and return empty output instead.On a side note, usage of both
repeatPull
andunconsFlatMap
inchunk*
operators and other methods is confusing at best. Especially as 'unconsFlatMap' to not use the operations defined inToPull
.For example, current implementation of
unconsLimit
will fail on negativen
whilechunkLimit
will produce infinite stream of empty chunks.