-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native "Array
-pointer" optimizations
#3061
Merged
mpilquist
merged 14 commits into
typelevel:main
from
armanbilge:topic/native-no-more-zones
Nov 20, 2022
Merged
Native "Array
-pointer" optimizations
#3061
mpilquist
merged 14 commits into
typelevel:main
from
armanbilge:topic/native-no-more-zones
Nov 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pic/native-no-more-zones
armanbilge
commented
Nov 20, 2022
Comment on lines
+32
to
+36
def fromBytePtr(ptr: Ptr[Byte], length: Int): Chunk[Byte] = { | ||
val bytes = new Array[Byte](length) | ||
memcpy(bytes.at(0), ptr, length.toULong) | ||
Chunk.ArraySlice(bytes, 0, length) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New public API
Comment on lines
+1
to
+6
{ | ||
inputs = { | ||
typelevel-nix.url = "github:typelevel/typelevel-nix"; | ||
nixpkgs.follows = "typelevel-nix/nixpkgs"; | ||
flake-utils.follows = "typelevel-nix/flake-utils"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erm, sorry, let's just say Ross got to me 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These optimizations take advantage of the ability to access the native pointer backing an
Array
as of Scala Native 0.4.8.