Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temporary file name generation on Node.js #3312

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

armanbilge
Copy link
Member

dir <- createTempDirectory(dir, prefix, permissions)
path = dir / Option(suffix).filter(_.nonEmpty).getOrElse(".tmp")
dir <- createTempDirectory(dir, "", permissions)
path = dir / (prefix + suffix)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't, in this way, all files have the same name? (Despite having different paths)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I don't think that's a problem, since the full path is unique.

@mpilquist mpilquist merged commit 30beea0 into typelevel:main Oct 3, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants