Refactor Node.js Duplex interop
#3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following in the steps of #3348, this PR replaces the
Dispatcher/Queue/Channelused forDuplexinterop with a custom concurrent data structure. Besides the performance benefits of removing indirection, this enables a semantics fix/enhancement: the FS2 upstream will not start until the Node.js downstream signals readiness. AFAIK it's not possible to implement this semantic with aQueuesince you cannot receive an (async) signal for readiness, only a signal when an enqueue completes.