Avoids converting from/to byte array from Chunk within UDP ASG single… #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuzzard
force-pushed
the
avoid-chunk-array-creation
branch
from
afa2749 to
d5334af
Compare
mpilquist
requested changes
Aug 28, 2017
| @@ -193,6 +199,10 @@ object AsynchronousSocketGroup { | |||
| } | |||
|
|
|||
| override def write(key: SelectionKey, packet: Packet, timeout: Option[FiniteDuration], cb: Option[Throwable] => Unit): Unit = { | |||
| val writerPacket = { | |||
| val b = packet.bytes.toBytes | |||
| new WriterPacket(packet.remote, ByteBuffer.wrap(if (b.size == b.values.size) b.values else b.values.slice(b.offset, b.size))) | |||
There was a problem hiding this comment.
Instead of using slice, let's use Array.copy instead
…ocket selector thread when doing writes by introducing an ASG private analog of the public Packet data type for the ASG writer which holds a ByteBuffer. The conversion from Chunk is done in the ASG write implementation prior to context switching to selector thread.
sbuzzard
force-pushed
the
avoid-chunk-array-creation
branch
from
d5334af to
ca6e66c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ton socket selector thread by introducing a package private analog of the public Packet data type which holds a byte array. The conversion from/to Chunk is done in the socket implementation prior to calling ASG.read or ASG write. More a proposal or query for better solution at this point. This does have the effect, at least in two applications, with eliminating the selector thread as a hot spot under load (one app, the client, creates 20 concurrent UDP connections and writes data at 38.8mbps to the 2nd app, which in turn manipulates the data and outputs it to third UDP destination).