Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 3.8.4 #880

Closed
wants to merge 3 commits into from

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scalameta:scalafmt-core from 3.8.3 to 3.8.4

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:n:3

@@ -27,7 +27,7 @@ import org.typelevel.log4cats.extras.DeferredLogMessage.{

/**
* `StructuredLogMessage` has a bug that can't be fixed without breaking bincompat (because it's a
* `case class`), but it's only used in the `Writer*Logger`s, so it's not a huge deal.
* `case class`), but it's only used in the `Writer*Logger` s, so it's not a huge deal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, what drives the Scalafmt rationale for this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I use this technique when the plural (-s, -es) or genitive (-'s) marker is correct in English but not in code. I don't like this change, but I like configuring scalafmt even less.

@typelevel-steward
Copy link
Contributor Author

Superseded by #882.

@typelevel-steward typelevel-steward bot deleted the update/scalafmt-core-3.8.4 branch January 17, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants