Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13 support #20

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Scala 2.13 support #20

merged 3 commits into from
Oct 2, 2019

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Sep 16, 2019

This PR adds the support of Scala 2.13.

Copy link
Member

@tpolecat tpolecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little things and I think it's good to go. Thanks!

.travis.yml Outdated
# run ci-release only if previous stages passed
- stage: release
script: sbt ci-release
script: sbt + ci-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci-release doesn't need +... it's a command that calls +publishSigned and so on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Done.

@@ -1,3 +1,7 @@
lazy val scala211Version = "2.11.12"
lazy val scala212Version = "2.12.10"
lazy val scala213Version = "2.13.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.13.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, kind-projector doesn't support 2.13.1.
Issue: typelevel/kind-projector#116.

Should we wait for their release first?

@tpolecat tpolecat merged commit 9fab465 into typelevel:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants