Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk-trace: add BatchSpanProcessor #390

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Dec 1, 2023

@iRevive iRevive added tracing Improvements to tracing module module:sdk Features and improvements to the sdk module labels Dec 1, 2023
@iRevive iRevive added this to the sdk-tracer milestone Dec 20, 2023
Copy link
Contributor

@NthPortal NthPortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks correct to me, though I'm not well versed in cats effect other than IO and Resource. sorry for how long it's taken me to review this

@iRevive
Copy link
Contributor Author

iRevive commented Jan 4, 2024

No worries, this PR does not block the development.

@iRevive iRevive force-pushed the sdk-trace/batch-span-processor branch from 60091c8 to 217fbe4 Compare January 7, 2024 09:45
@iRevive iRevive merged commit 9baff2d into typelevel:main Jan 7, 2024
10 checks passed
@iRevive iRevive deleted the sdk-trace/batch-span-processor branch January 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:sdk Features and improvements to the sdk module tracing Improvements to tracing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants