-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update opentelemetry-semconv to 1.26.0-alpha #706
Conversation
Executed command: sbt ; root/semanticConventionsGenerate; headerCreateAll; scalafixAll; scalafmtAll
@@ -67,6 +67,7 @@ object SemanticConventionsGenerator { | |||
"--file-per-group", "root_namespace", | |||
// Space delimited list of root namespaces to excluded (i.e. "foo bar") | |||
"-Dexcluded_namespaces=\"ios aspnetcore signalr\"", | |||
"-Dexcluded_attributes=messaging.client_id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generator produces identical attribute names for both attribute.name
and attribute_name
. Consequently, if the attribute is renamed (changing _
to .
or vice versa), its value changes while its name remains unchanged.
See:
@@ -576,6 +576,7 @@ lazy val `semconv-experimental` = | |||
startYear := Some(2023), | |||
// We use opentelemetry-semconv dependency to track releases of the OpenTelemetry semantic convention spec | |||
libraryDependencies += "io.opentelemetry.semconv" % "opentelemetry-semconv-incubating" % OpenTelemetrySemConvVersion % "compile-internal" intransitive (), | |||
mimaPreviousArtifacts := Set.empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module is experimental and we cannot offer binary guarantees there. It should be safe to disable MiMa checks.
* including the keyspace name (if applicable). | ||
/** Deprecated, use `db.collection.name` instead. | ||
*/ | ||
@deprecated("Use `db.collection.name` instead", "0.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I'm so late with pointing this out (was sick), but the since
version is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value is hardcoded in the template and we cannot determine it dynamically :(
https://github.com/typelevel/otel4s/blob/main/buildscripts/semantic-convention/templates/SemanticAttributes.scala.j2#L88
I guess the best option is to use an empty string instead. At least we will not mislead users.
About this PR
📦 Updates io.opentelemetry.semconv:opentelemetry-semconv from
1.25.0-alpha
to1.26.0-alpha
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: