Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the relaxedMode & strictMode commands #48

Closed

Conversation

BalmungSan
Copy link

The idea of this PR is to allow users to quickly enable / disable fatal-warnings.

I am open to changing the names of the commands; since I don't think they are clear enough, but I wasn't able to come with better names.
Also, not sure if we should add some tests (and how should I do it).

Finally, maybe it would be good to not hard code it to -Xfatal-warnings; but rather retrieve the right one from the current version. WDYT?

@SethTisue
Copy link
Member

does this work in multi-project builds?

@BalmungSan
Copy link
Author

@SethTisue

does this work in multi-project builds?

No, it did not. Thanks for the heads up!

I just pushed a fix for that, I already tested it in my local and works great with multi-project builds and it plays nicely with metals (at least when sbt is the BSP, I guess that when using bloop one would need to re-import the build).

@SethTisue
Copy link
Member

Add the SBT_TPOLECAT_RELAXED env var switch

I would not describe @tpolecat as "relaxed" on the subject of sbt ;-)

@seveneves
Copy link

Hi @DavidGregory084
Any plans on merging this?

@DavidGregory084
Copy link
Member

Sorry @BalmungSan @seveneves I have been swamped by UK transit projects for a really long time but I have escaped now.

I've started a larger discussion about this PR on #49, looking forward to reading your thoughts

@DavidGregory084
Copy link
Member

@seveneves please see #54 which expands upon this idea a bit and let me know what you think!

@BalmungSan
Copy link
Author

Superseded by #54

@BalmungSan BalmungSan closed this Mar 29, 2022
@BalmungSan BalmungSan deleted the add-relaxed-mode-command branch March 29, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants