You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The site plugin contains the tlSitePublishBranch setting which could have a None value. But that would mean the site will still publishing just only for tags. There are cases when building the site is fine, but publishing is redundant. It's the case of the multibranch project without a versioned site. A versioned site for such projects could be redundant at all. So it would be nice to have the ability to disable site publishing from plugin settings.
On the other hand, one can set tlSitePublishBranch to the main branch from which the site will be publishing, but it would be more clear if one can explicitly disable the publishing site.
So this proposal is just about getting more configurable behavior through explicit settings rather than getting functionality at all.
The text was updated successfully, but these errors were encountered:
Yeah I was thinking this yesterday too. You are right that it is confusing. We could add a tlSitePublishTags := true/false setting but then raise an error if this is true and tlSitePublishBranche := Some(...) because you can only publish from one thing.
There are cases when building the site is fine, but publishing is redundant. It's the case of the multibranch project without a versioned site.
Out of curiosity: if you are not publishing the site from an old branch, is there a point to building it?
Out of curiosity: if you are not publishing the site from an old branch, is there a point to building it?
It's a sort of thin ice, I guess. The older branches shouldn't have docs (I mean site) then. But one day, a project may decide to have a versioned site. Then backporting it from upstream would be pretty painful.
This was born from a discussion typelevel/log4cats#603 (review).
The site plugin contains the
tlSitePublishBranch
setting which could have aNone
value. But that would mean the site will still publishing just only for tags. There are cases when building the site is fine, but publishing is redundant. It's the case of the multibranch project without a versioned site. A versioned site for such projects could be redundant at all. So it would be nice to have the ability to disable site publishing from plugin settings.On the other hand, one can set
tlSitePublishBranch
to themain
branch from which the site will be publishing, but it would be more clear if one can explicitly disable the publishing site.So this proposal is just about getting more configurable behavior through explicit settings rather than getting functionality at all.
The text was updated successfully, but these errors were encountered: