Add the tlSitePublishTags setting
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
commented
Feb 21, 2022
site/src/main/scala/org/typelevel/sbt/TypelevelSitePlugin.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Feb 21, 2022
site/src/main/scala/org/typelevel/sbt/TypelevelSitePlugin.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
armanbilge
reviewed
Feb 21, 2022
site/src/main/scala/org/typelevel/sbt/TypelevelSitePlugin.scala
Outdated
Show resolved
Hide resolved
armanbilge
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Thanks for fixing this one, it was my fault to make it so confusing.
I think in general publishing site from tag can be a "thin ice" as you say. The problem is that tags can happen on any branch, including old ones, or new development branch. So if you forget to disable this setting and don't setup versioned sites, then if you publish an early milestone tag you could accidentally override your site for the stable version.
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
|
So, is this waiting for something? |
|
Because sbt-typelevel publishes the site on every push, and you updated the docs in this PR (thanks for that!), I'll merge this one right before I release so that the docs are not predicting the future 😉 |
|
Thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137. Implemented the way as @armanbilge suggested.