Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiMa setting for Scalajs milestones #482

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

ashawley
Copy link
Contributor

A cherry-picked version of #475 to master branch.

@non
Copy link
Contributor

non commented Aug 6, 2019

👍

@non
Copy link
Contributor

non commented Aug 6, 2019

One question about all of this: most projects explicitly set a ScalaJS version in project/plugins.sbt which is used in all cases. I noticed ScalaCheck seems to have a set up where particular users can change the version with an environment variable (SCALAJS_VERSION).

Is this desirable? Maybe I'm out of touch with modern ScalaJS practices but it seems to me like it would be better to make the build/release process more standardized rather than requiring extra environment variables to be set.

(I'm planning to merge this either way, I'm just going to be refactoring the build to make it possible for me to do a ScalaCheck release and I want to figure out if this environment variable stuff is something I can tear out or not.)

@ashawley
Copy link
Contributor Author

ashawley commented Aug 6, 2019

Yeah, I agree it's clunky, but I'm not aware of another way.

@non
Copy link
Contributor

non commented Aug 6, 2019

I'm going to merge this as-is (but it might end up getting changed when I refactor the build).

Thanks!

@non non merged commit 4c8110a into typelevel:master Aug 6, 2019
@ashawley ashawley deleted the scalajs-1.x-milestone-mima branch August 7, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants