Fix Gen.pick when used with Gen[_] arguments. #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when called with generators Gen.pick could return collections of
any length, when the API promises that they are length `n`.
// should only generate Seq(0,1), Seq(0,2), or Seq(1,2).
val g = Gen.pick(2, Gen.const(0), Gen.const(1), Gen.const(2))
We didn't have a test for this variant of Gen, which explains why we didn't
detect this breakage.
|
(I'm not sure how widely this variant of |
ashawley
reviewed
Nov 2, 2020
| val gs = rest.map(Gen.const) | ||
| Try(pick(n, Gen.const(x), Gen.const(y), gs: _*)) match { | ||
| case Success(g) => | ||
| forAll(g) { m => m.length == n && m.forall(lst.contains) } |
There was a problem hiding this comment.
Does this assertion need to be m.forall(x :: y :: lst.contains)?
There was a problem hiding this comment.
That has a syntax error, but hopefully you catch my drift.
There was a problem hiding this comment.
No because val lst = x :: y :: rest.
There was a problem hiding this comment.
So it is. I read lst as rest.
larsrh
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when called with generators Gen.pick could return collections of
any length, when the API promises that they are length
n.We didn't have a test for this variant of Gen, which explains why we didn't
detect this breakage.