Migrate to sbt-typelevel #875

armanbilge · 2022-03-02T07:36:50Z

No description provided.

armanbilge · 2022-03-02T07:51:06Z

core/shared/src/main/scala/org/scalacheck/util/Buildable.scala

-  private[scalacheck] implicit def buildableSeq[T]: Buildable[T, Seq[T]] =
+  def buildableSeq[T]: Buildable[T, Seq[T]] =
    new Buildable[T, Seq[T]] {
      def builder: mutable.Builder[T, Seq[T]] =
        Seq.newBuilder[T]
    }
+
+  private[scalacheck] implicit def implicitBuildableSeq[T]: Buildable[T, Seq[T]] = buildableSeq


A minor thing, but lets us keep bincompat with a static forwarder without adding an exclusion.

The problem was introduced in #788 (see discussion there).

armanbilge · 2022-03-02T07:52:21Z

build.sbt

+ThisBuild / tlBaseVersion := "1.15"
+ThisBuild / tlMimaPreviousVersions ++= Set(
+  // manually added because tags are not v-prefixed
+  "1.14.0",
+  "1.14.1",
+  "1.14.2",
+  "1.14.3",
+  "1.15.0",
+  "1.15.1",
+  "1.15.2",
+  "1.15.3",
+  "1.15.4",
 )


This is annoying, but gets the job done.

Any objection to using early-semver for scalacheck going forward?

As an alternative to regular semver? What's the difference when we're past 0.x?

For some reason I thought scalacheck may be using PVP? Happy to be wrong.

Yeah, the release notes say 1.14.x is not backwards-compatible with anything before it.
https://github.com/typelevel/scalacheck/blob/main/CHANGELOG.markdown#1140-2018-04-22

Oh, yeah. The breaking change in a minor version was a driver for a major version bump in libraries as prominent as Cats. Binary compatibility weighs very heavily on this project, and we shouldn't do that again.

armanbilge · 2022-03-02T07:58:03Z

build.sbt


+ThisBuild / crossScalaVersions := Seq(Scala3, Scala212, Scala213)


This PR restores the single Scala 3 build. Of course, we can't merge it today, but once the -Yscala-release flag arrives I think this should work fine.

Incidentally, you'll find that CI is running Scala 3 + Native jobs :)

Actually, we could dial this back to Scala 3.0.2 and merge this today.

armanbilge · 2022-03-03T01:01:44Z

Woops, conflicts...

rossabaker

Seems good to me. Requesting changes to make sure the Scala 3 gets rolled back to 3.0.2, or else we're deciding for the whole world.

rossabaker · 2022-03-07T04:08:55Z

build.sbt

+ThisBuild / tlBaseVersion := "1.15"
+ThisBuild / tlMimaPreviousVersions ++= Set(
+  // manually added because tags are not v-prefixed
+  "1.14.0",
+  "1.14.1",
+  "1.14.2",
+  "1.14.3",
+  "1.15.0",
+  "1.15.1",
+  "1.15.2",
+  "1.15.3",
+  "1.15.4",
 )


As an alternative to regular semver? What's the difference when we're past 0.x?

rossabaker · 2022-03-07T04:17:10Z

Does this supersede #860?

armanbilge · 2022-03-07T04:22:34Z

Yes, supersedes #860 with apologies to @vasilmkd who put a lot of time/effort into it as well. Also closes #625.

I rolled back to 3.0.2 and removed the Native/Scala3 job. Should be good to go.

rossabaker · 2022-03-07T04:24:32Z

I didn't understand we lose native support on Scala 3 with this rollback. So our choices are:

Keep blocking native support on Scala 3
Force an upgrade on all the JVM clients that have stuck to 3.0 (or make them pin scalacheck too)
Complicate this further by publshing the JVM on 3.0 and Native on 3.1

?

armanbilge · 2022-03-07T04:28:26Z

Yes, Scala Native requires 3.1. I think we should wait until the new -Yscala-release flag arrives in 3.1.2, at which point we can compile all platforms on Scala 3.1 without forcing any downstream to upgrade.

FWIW, scalameta/munit#477 is an important PR blocked by this one, and they are also waiting for the new flag.

armanbilge · 2022-03-07T04:30:27Z

See also portable-scala/sbt-crossproject#130 for why I don't want to mess around with option (3).

rossabaker · 2022-03-07T04:42:13Z

I suppose a fourth option is a prerelease as the next minor version that builds for Scala 3.1, with the assumption that Scala 3.1.2 will precede it.

As someone almost entirely on Scala 2 and not at all on Scala Native, easy for me to say, but I'm content to wait.

armanbilge · 2022-03-07T04:44:50Z

I'd be happy to get this PR merged as-is, and then we can discuss the Native/3 situation :)

rossabaker

I've never been a primary maintainer, so I won't hit the green button, but if nobody objects in the next couple days, I will.

armanbilge · 2022-03-07T04:52:37Z

Thanks!

Gah, conflicts again!

rossabaker · 2022-03-07T04:55:16Z

Sorry, I just merged one that had been approved for months.

armanbilge · 2022-03-07T04:56:16Z

No worries, I'm glad to see activity here :)

SethTisue · 2022-03-15T13:18:22Z

I've never been a primary maintainer

I'm not sure if any of us here are "primary maintainer"s anymore

armanbilge added 6 commits February 20, 2022 10:03

WIP migrate to sbt-typelevel

42b93f6

Configure mima

60d80b6

Regenerate workflow

1f92505

Fix bincompat

15670c8

... but preserve internal source-compat

8177c0c

Anticipate Scala3/Native release

bd0e03f

armanbilge mentioned this pull request Mar 2, 2022

sbt-typelevel adoption typelevel/sbt-typelevel#83

Open

44 tasks

armanbilge added 2 commits March 2, 2022 07:43

Make workflow independent of ++

27ea54c

Remove useless settings

cf0719c

armanbilge commented Mar 2, 2022

View reviewed changes

Merge branch 'main' into topic/sbt-typelevel

6213898

armanbilge marked this pull request as ready for review March 3, 2022 01:03

rossabaker requested changes Mar 7, 2022

View reviewed changes

rossabaker mentioned this pull request Mar 7, 2022

support scala-native Scala 3 build #868

Closed

Roll back to Scala 3.0.2

bc1a177

rossabaker approved these changes Mar 7, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/main' into topic/sbt-typelevel

b3a944d

vasilmkd mentioned this pull request Mar 7, 2022

Set up a proper cross build #860

Closed

SethTisue merged commit 6ee7f25 into typelevel:main Mar 15, 2022

armanbilge mentioned this pull request Mar 15, 2022

Drop Scala 3.0, publish for 3.1? #878

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to sbt-typelevel #875

Migrate to sbt-typelevel #875

armanbilge commented Mar 2, 2022

armanbilge Mar 2, 2022

armanbilge Mar 2, 2022

rossabaker Mar 7, 2022

armanbilge Mar 7, 2022

armanbilge Mar 7, 2022

rossabaker Mar 7, 2022

armanbilge Mar 2, 2022

armanbilge Mar 2, 2022

armanbilge commented Mar 3, 2022

rossabaker left a comment

rossabaker Mar 7, 2022

rossabaker commented Mar 7, 2022

armanbilge commented Mar 7, 2022

rossabaker commented Mar 7, 2022

armanbilge commented Mar 7, 2022 •

edited

Loading

armanbilge commented Mar 7, 2022

rossabaker commented Mar 7, 2022

armanbilge commented Mar 7, 2022

rossabaker left a comment

armanbilge commented Mar 7, 2022

rossabaker commented Mar 7, 2022

armanbilge commented Mar 7, 2022

SethTisue commented Mar 15, 2022


		ThisBuild / crossScalaVersions := Seq(Scala3, Scala212, Scala213)

Migrate to sbt-typelevel #875

Migrate to sbt-typelevel #875

Conversation

armanbilge commented Mar 2, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

armanbilge commented Mar 3, 2022

rossabaker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rossabaker commented Mar 7, 2022

armanbilge commented Mar 7, 2022

rossabaker commented Mar 7, 2022

armanbilge commented Mar 7, 2022 • edited Loading

armanbilge commented Mar 7, 2022

rossabaker commented Mar 7, 2022

armanbilge commented Mar 7, 2022

rossabaker left a comment

Choose a reason for hiding this comment

armanbilge commented Mar 7, 2022

rossabaker commented Mar 7, 2022

armanbilge commented Mar 7, 2022

SethTisue commented Mar 15, 2022

armanbilge commented Mar 7, 2022 •

edited

Loading