Merge pull request #901 from wonk1132/alterDb

add ALTER DATABASE to completion/commandcomplete
typelevel · Jun 30, 2023 · 9ac10b7 · 9ac10b7
2 parents 800d304 + fb74951
commit 9ac10b7
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/modules/core/shared/src/main/scala/data/Completion.scala b/modules/core/shared/src/main/scala/data/Completion.scala
@@ -49,6 +49,7 @@ object Completion {
   case object DropSequence              extends Completion
   case object CreateDatabase            extends Completion
   case object DropDatabase              extends Completion
+  case object AlterDatabase             extends Completion
   case object CreateRole                extends Completion
   case object DropRole                  extends Completion
   case object CreateMaterializedView    extends Completion

diff --git a/modules/core/shared/src/main/scala/net/message/CommandComplete.scala b/modules/core/shared/src/main/scala/net/message/CommandComplete.scala
@@ -82,6 +82,7 @@ object CommandComplete {
     case "DROP SEQUENCE"              => apply(Completion.DropSequence)
     case "CREATE DATABASE"            => apply(Completion.CreateDatabase)
     case "DROP DATABASE"              => apply(Completion.DropDatabase)
+    case "ALTER DATABASE"             => apply(Completion.AlterDatabase)
     case "CREATE ROLE"                => apply(Completion.CreateRole)
     case "DROP ROLE"                  => apply(Completion.DropRole)
     case "CREATE MATERIALIZED VIEW"   => apply(Completion.CreateMaterializedView)

diff --git a/modules/tests/shared/src/test/scala/CommandTest.scala b/modules/tests/shared/src/test/scala/CommandTest.scala
@@ -220,6 +220,16 @@ class CommandTest extends SkunkTest {
         CREATE DATABASE skunk_database
        """.command
 
+  val alterDatabaseTemplateOn: Command[Void] =
+    sql"""
+       ALTER DATABASE skunk_database WITH is_template = TRUE
+       """.command
+
+  val alterDatabaseTemplateOff: Command[Void] =
+    sql"""
+       ALTER DATABASE skunk_database WITH is_template = FALSE
+       """.command
+
   val dropDatabase: Command[Void] =
     sql"""
         DROP DATABASE IF EXISTS skunk_database
@@ -421,10 +431,17 @@ class CommandTest extends SkunkTest {
     } yield "ok"
   }
 
-  sessionTest("create database, drop database"){ s=>
+  sessionTest("create database, alter database, drop database"){ s=>
     for{
       c <- s.execute(createDatabase)
       _ <- assert("completion", c == Completion.CreateDatabase)
+      acOn <- s.execute(alterDatabaseTemplateOn)
+      _ <- assert("completion", acOn == Completion.AlterDatabase)
+
+      // in order to drop a database, it must not be a template, so flip template = false again
+      acOff <- s.execute(alterDatabaseTemplateOff)
+
+      _ <- assert("completion", acOff == Completion.AlterDatabase)
       c <- s.execute(dropDatabase)
       _ <- assert("completion", c == Completion.DropDatabase)
     } yield "ok"