Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal usage of mirrors to use refinement types #706

Closed
mpilquist opened this issue Sep 22, 2022 · 0 comments
Closed

Update internal usage of mirrors to use refinement types #706

mpilquist opened this issue Sep 22, 2022 · 0 comments

Comments

@mpilquist
Copy link
Member

Now that scala/scala3#7380 has been fixed, we can replace this idiom:

using m: Mirror.ProductOf[P], i: m.MirroredElemTypes =:= A *: EmptyTuple

with:

using m: Mirror.ProductOf[P] { type MirroredElemTypes = A *: EmptyTuple }

To retain binary compatibility, we'd have to retain the existing signatures as private[skunk] for the various operations that have already been released. See scodec/scodec@919f964 for a similar change that was done to scodec.

mpilquist added a commit that referenced this issue Sep 22, 2022
Use refinement types on mirrors - fixes #706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant