Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic select benchmarks #1048

Merged

Conversation

AlekseiLitkovetc
Copy link
Contributor

Hello @tpolecat,

Thank you so much for such a cool data access library. I see how much effort and time was invested in researching this topic and implementing such a wonderful tool as Skunk. Thank you 🙏

Recently, I noticed that the Skunk repository doesn't have benchmarks. If you don't mind, can we add some basic selection tests similar to those in the Doobie repository? In case this work is relevant, we can also consider adding more tests (for example, to test DML operations). And I will be glad to help with it.

Thank you in advance!

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 84.10%. Comparing base (3f99149) to head (a85ead3).

Files Patch % Lines
...bench/src/main/scala/skunk/bench/SelectBench.scala 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   85.54%   84.10%   -1.45%     
==========================================
  Files         135      136       +1     
  Lines        2041     2076      +35     
  Branches      239      243       +4     
==========================================
  Hits         1746     1746              
- Misses        295      330      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpilquist
Copy link
Member

This sounds great, thanks!

@mpilquist mpilquist merged commit fbe933b into typelevel:main Feb 25, 2024
10 checks passed
@AlekseiLitkovetc
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants