Fix bug in semispace cache that allowed gen1 to contain values in evi… #1162
+57
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilquist
reviewed
Jan 14, 2025
| else SemispaceCache(Map(k -> v), gen0, max, evicted ++ gen1.values - v)// no room in gen0, slide it down | ||
| def insert(k: K, v: V): SemispaceCache[K, V] = | ||
| if (max == 0) SemispaceCache(gen0, gen1, max, evicted + v) // immediately evict | ||
| else if (gen0.size < max) SemispaceCache(gen0 + (k -> v), gen1 - k, max, evicted - v) // room in gen0, remove from gen1, done! |
There was a problem hiding this comment.
If gen0 or gen1 contains (k, v0) such that v0 != v, we should add v0 to evicted list. Likewise below.
mpilquist
reviewed
Jan 14, 2025
| new SemispaceCache[K, V](gen0, gen1, max, evicted) {} | ||
| private def apply[K, V](gen0: Map[K, V], gen1: Map[K, V], max: Int, evicted: EvictionSet[V]): SemispaceCache[K, V] = { | ||
| val r = new SemispaceCache[K, V](gen0, gen1, max, evicted) {} | ||
| val gen0Intersection: Set[V] = (gen0.values.toSet intersect evicted.toList.toSet) |
There was a problem hiding this comment.
Drop these assertions now? I worry a bit about all these set creations/intersections on each constructor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cted.