Replace SemispaceCache with LRU Cache #1163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
SemispaceCache
and adds a least recently used cache (creatively namedCache
). This improves cache behavior, especially with access patterns where cached entries were promoted from gen 1 to gen 0 and resultantly lots of cached statements would be evicted.The LRU implementation is based on maps and access stamps -- not particularly storage efficient but should be good enough for this use case. I thought about implementing this with a splay tree instead but opted for the hash map design.
The configured max cache space is accurately enforced now, whereas
SemispaceCache
would store up to twice the configured max. Hence, the session defaults were all doubled to get the same net maximum.Eviction tracking is NOT built in to
Cache
like it was inSemispaceCache
. Instead, putting an element in to a cache returns the element that was evicted as a result, if any. Eviction tracking moved up in toStatementCache
instead.cc @matthughes