Use Mutex instead of Semaphore(1)
#853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Apr 22, 2023
| new Exchange[F] { | ||
| override def apply[A](fa: F[A]): F[A] = | ||
| sem.permit.use(_ => fa).uncancelable | ||
| mut.lock.surround(fa).uncancelable |
There was a problem hiding this comment.
While we're here, I wonder about this being .uncancelable. Should the lock acquisition be uncancelable as well? 🤔 or would mut.lock.surround(fa.uncancelable) be sufficient.
Codecov Report
@@ Coverage Diff @@
## main #853 +/- ##
=======================================
Coverage 85.07% 85.07%
=======================================
Files 126 126
Lines 1742 1742
Branches 147 147
=======================================
Hits 1482 1482
Misses 260 260
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.