Fix cancelation when waiting on pool #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Jul 10, 2023
Comment on lines
113
to
130
| recycler(a._1).onError { | ||
| case t => dispose(a) *> t.raiseError[F, Unit] | ||
| } flatMap { | ||
| recycler(a._1).onError { _ => dispose(a) } flatMap { |
There was a problem hiding this comment.
Unrelated fix, similar to #906. Skunk has a habit of re-raising errors 😅
Comment on lines
+115
to
+118
| val wait = | ||
| poll(d.get) | ||
| .onCancel(cancel) | ||
| .flatMap(_.liftTo[F].onError(restore)) |
There was a problem hiding this comment.
We need to be careful on cancelation that nobody has completed the deferred in the meantime.
Codecov Report
@@ Coverage Diff @@
## series/0.6.x #919 +/- ##
================================================
+ Coverage 84.25% 84.30% +0.04%
================================================
Files 126 126
Lines 1734 1733 -1
Branches 171 166 -5
================================================
Hits 1461 1461
+ Misses 273 272 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to cancel when waiting on a resource from the pool. Previously this was not possible, so cancelation would hang until the resource became available in the pool, such that it could be immediately returned :)
Thanks to @yurique for reporting!