-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to algebra 2.7.0 #1115
Update to algebra 2.7.0 #1115
Changes from all commits
c82176c
4c1191f
e25ae68
903bc04
b34a8d2
1d10d88
08dac4c
8247869
508aedf
d154514
10f00ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,7 +83,7 @@ final class SignedOps[A](a: A)(using s: Signed[A]): | |
def isSignNonNegative: Boolean = s.isSignNonNegative(a) | ||
|
||
final class TruncatedDivisionOps[A](lhs: A)(using ev: TruncatedDivision[A]): | ||
def toBigIntOpt: Opt[BigInt] = ev.toBigIntOpt(lhs) | ||
// def toBigIntOpt: Opt[BigInt] = ev.toBigIntOpt(lhs) // TODO port to algebra? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be an API change, why? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could it be implemented in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For some reason it wasn't included in typelevel/algebra#247. I think it would be good if we could continue to implement it in spire, but I wasn't sure how unless we introduce a new typeclass? Any ideas? |
||
def tquot(rhs: A): A = ev.tquot(lhs, rhs) | ||
def tmod(rhs: A): A = ev.tmod(lhs, rhs) | ||
def tquotmod(rhs: A): (A, A) = ev.tquotmod(lhs, rhs) | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be rename to
catsVersion
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah,
catsVersion
=algebraVersion
now. But since we don't explicitly depend on cats, I think this is fine for now.