Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prettier + TSLint section #14

Merged
merged 6 commits into from
Jun 6, 2018
Merged

Update Prettier + TSLint section #14

merged 6 commits into from
Jun 6, 2018

Conversation

azdanov
Copy link
Contributor

@azdanov azdanov commented Jun 4, 2018

Added some info on how to integrate prettier with tslint.

@tsiq-swyx
Copy link
Contributor

thanks! you want to add a comment about the ESlint setup? can point people to our discussion there (#7) so that they can get help if they need it. then we can remove the "active discussion" sentence.

@azdanov
Copy link
Contributor Author

azdanov commented Jun 4, 2018

Of course. Didn't have much time today. Will add more tomorrow.

@tsiq-swyx
Copy link
Contributor

LGTM! anything else you want to discuss? im happy to merge this. @Attrash-Islam in case you have any opinions here

Copy link
Contributor

@tsiq-swyx tsiq-swyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, i love the table format, we might want to adopt this in other parts of the cheatsheet!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@azdanov
Copy link
Contributor Author

azdanov commented Jun 6, 2018

Would it be a good idea to link an example repo, the one I've used in the respective issue?

@tsiq-swyx
Copy link
Contributor

@azdanov absolutely, we love links in this cheatsheet. lets people go and explore on their own but keeps our content short.

Anton Zdanov and others added 2 commits June 6, 2018 18:56
An example repository for integrating prettier, eslint and tslint together.
@tsiq-swyx
Copy link
Contributor

this all looks great, thank you so much for your contribution @azdanov! personally im quite curious if more people will want to try out using your ESLint setup when they see this :)

@tsiq-swyx tsiq-swyx merged commit b88c3d7 into typescript-cheatsheets:master Jun 6, 2018
@azdanov azdanov deleted the patch-1 branch June 6, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants