Skip to content

Cannot read package files on Windows #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Jul 5, 2021 · 2 comments · Fixed by #1151 or #1247
Closed

Cannot read package files on Windows #1150

JoshuaKGoldberg opened this issue Jul 5, 2021 · 2 comments · Fixed by #1151 or #1247
Assignees
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Jul 5, 2021

🐛 Bug Report

  • tslint-to-eslint-config version: 2.6.0
  • ESLint version: N/A
  • Node version: 12.X, 14.X

Actual Behavior

When trying to find package.json dependencies, cat path/to/package.json is a CLI command that gets run.

Expected Behavior

cat doesn't exist on Windows.

Reproduction

On Windows, npx tslint-to-eslint-config and see the error in findOriginalConfigurations for package.

Spotted in #1149.

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jul 5, 2021
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working labels Jul 5, 2021
@JoshuaKGoldberg
Copy link
Member Author

I believe #1151 is the right fix and I should recreate it, but I'm waiting for confirmation in angular-eslint/angular-eslint#571 to be sure.

@JoshuaKGoldberg
Copy link
Member Author

angular-eslint/angular-eslint#571 (comment)

Hmm, I'm not convinced this won't come back again if I revert the revert. The original issue (typescript-eslint/tslint-to-eslint-config#1150) is that tslint-to-eslint-config tries using cat on Windows. I can switch that to using type on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working
Projects
None yet
1 participant