Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support ordered-imports option #1402

Merged
merged 4 commits into from
Feb 21, 2023
Merged

feat: Support ordered-imports option #1402

merged 4 commits into from
Feb 21, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Mar 3, 2022 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Simply adds support for the ordered-imports option. This is a draft PR because the correct functionality depends on a PR within eslint-plugin-import

@hyperupcall hyperupcall mentioned this pull request Mar 3, 2022
Merged
@hyperupcall
Copy link
Contributor Author

Just an update on this PR - My bugfix for eslint-plugin-import just got merged, so once there is a new release, i'll make the final modifications required to undraft this PR 🎉

@hyperupcall hyperupcall marked this pull request as ready for review February 21, 2023 20:33
@hyperupcall
Copy link
Contributor Author

hyperupcall commented Feb 21, 2023 •
edited
Loading

Wowzies! I think this thing is ready for review again - glad this can finally be closed soon 😅

According to GitHub, my eslint-plugin-import change got released in v2.27.0, which was released on January 11, so everyone should have an update-to-date version when they install the package after the config conversion.

The most recent changes just set distinctGroup to false. Supposedly in a later update, the default will be changed to false, as doing so is simply a bug fix.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a blast from the past! This is looking great, thanks @hyperupcall!

Congrats on getting this merged after all these months 😄

src/converters/lintConfigs/rules/ruleConverters/ordered-imports.ts

if ("groups" in argument) {
notices.push(
"Option 'groups' is too bespoke to be converted to ESLint plugin 'eslint-plugin-import'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 I love this

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2675a01 into typescript-eslint:main Feb 21, 2023
@JoshuaKGoldberg
Copy link
Member

Should be published & available in 2.14.0. Thanks @hyperupcall! 🙌

@hyperupcall
Copy link
Contributor Author

Yay! Happy to help 😃

@hyperupcall hyperupcall deleted the converter-ordered-imports branch February 21, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using an eslint import plugin instead of import/order
2 participants
@hyperupcall @JoshuaKGoldberg