[Bugfix] Replace removed rules #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
added
the
status: waiting for reviewer
KingDarBoja
changed the title
JoshuaKGoldberg
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Fixes these rule converters:
@typescript-eslint/prefer-interfaceis replaced by@typescript-eslint/consistent-type-definitions.@typescript-eslint/no-object-literal-type-assertionand@typescript-eslint/no-angle-bracket-type-assertionare combined in to one single rule@typescript-eslint/consistent-type-assertionsI am a bit worried about the
no-object-literal-type-assertionone because it has one option calledallow-argumentswhich can be set to true to allow type casting inside a function/class argument.Check TSLint rule and compare against Typescript-ESLint one.