-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added recommended --prettier flag to include eslint-config-prettier #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
changed the title
Made extending eslint-config-prettier built-in, with --ugly flag to opt out
Added recommended --prettier flag to include eslint-config-prettier
Apr 26, 2020
JoshuaKGoldberg
commented
Apr 26, 2020
@@ -67,7 +67,7 @@ export const findESLintConfiguration = async ( | |||
full: { | |||
...defaultESLintConfiguration, | |||
...reportedConfiguration, | |||
extends: Array.from(new Set(extensions)), | |||
extends: extensions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight cleanup: uniqueFromSources
already deduplicates with Array.from(new Set(
.
This was referenced May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
When
--prettier
is enabled,eslint-config-prettier
will always be added to the list of ESLint plugins.When
--prettier
isn't enabled:eslint-config-prettier
.--prettier
.Declares typings in a
.d.ts
file pending DefinitelyTyped/DefinitelyTyped#44245.