Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 5.1 Support #6934

Closed
bradzacher opened this issue Apr 19, 2023 · 3 comments · Fixed by #7088
Closed

TypeScript 5.1 Support #6934

bradzacher opened this issue Apr 19, 2023 · 3 comments · Fixed by #7088
Labels
dependencies Issue about dependencies of the package New TypeScript Version

Comments

@bradzacher
Copy link
Member

bradzacher commented Apr 19, 2023

https://devblogs.microsoft.com/typescript/announcing-typescript-5-1-beta/

This issue is just to track all of the new features and their implementation state in this project.
As with all releases, we will not necessarily to support all features until closer to the full release when everything the features are stabilised.

Please be patient.

✅ ES2020 and Node.js 14.17 as Minimum Runtime Requirements

As part of our upcoming v6 release we've bumped our minimum node to v16.

This does not impact us as it's up to the user to use a supported node version for their selected TS version.

✅ lib.d.ts Updates

We will need to regenerate our types within scope-manager.


Other changes with no impact to us

  • Easier Implicit Returns for undefined-Returning Functions
  • Unrelated Types for Getters and Setters
  • Decoupled Type-Checking Between JSX Elements and JSX Tag Types
  • Namespaced JSX Attributes
  • typeRoots Are Consulted In Module Resolution
  • Linked Cursors for JSX Tags
  • Snippet Completions for @param JSDoc Tags
  • Avoiding Unnecessary Type Instantiation
  • Negative Case Checks for Union Literals
  • Reduced Calls into Scanner for JSDoc Parsing
  • Explicit typeRoots Disables Upward Walks for node_modules/@types
@bradzacher bradzacher added dependencies Issue about dependencies of the package New TypeScript Version labels Apr 19, 2023
@bradzacher bradzacher pinned this issue Jun 2, 2023
mihaip added a commit to mihaip/infinite-mac that referenced this issue Jun 2, 2023
Incldues also running linting and tsc checks over the worker.

Not upgrading to 5.1 yet because the ESLint plugin has not been updated
for it yet (typescript-eslint/typescript-eslint#6934).
@Josef-Reichardt
Copy link

Josef-Reichardt commented Jun 5, 2023

Typescript 5.1.3 is now officially released: https://github.com/microsoft/TypeScript/releases/tag/v5.1.3

So I think this is going to hit a lot of people from now on.

@typescript-eslint typescript-eslint deleted a comment from Shereef Jun 5, 2023
@bradzacher
Copy link
Member Author

bradzacher commented Jun 5, 2023

Please refrain from commenting asking for status updates and from posting the warning log our tool emits.

We are aware that 5.1 has released, and it is on our radar to support.

We volunteer maintainers will get to this when we have the bandwidth. Unfortunately of late we have all been tied up with personal matters.

It will not be in the next release (which I believe will automatically be cut in a few hours). We may be able to target next week, time permitting.

@bradzacher
Copy link
Member Author

Just to close the loop for those waiting for true support.
We've hit a regression in TS 5.1 which is causing our tests to OOM.
We're working with the TS team to resolve this.

Based on Josh's work so far it looks like our tooling should be fine out-of-the-box on TS5.1 - but if you encounter weird behaviour please revert to TS5.0 and wait for us to officially release.

sjdemartini added a commit to sjdemartini/mui-tiptap that referenced this issue Jun 15, 2023
This does not yet resolve typescript-eslint's warnings about TS 5.1, but
they say there shouldn't be any explicit incompatibility:
typescript-eslint/typescript-eslint#6934
sjdemartini added a commit to sjdemartini/mui-tiptap that referenced this issue Jun 15, 2023
This does not yet resolve typescript-eslint's warnings about TS 5.1, but
they say there shouldn't be any explicit incompatibility:
typescript-eslint/typescript-eslint#6934
henrybell added a commit to google-github-actions/create-cloud-deploy-release that referenced this issue Jun 28, 2023
Automated update excluding `typescript`, which has a minor release [not
yet officially supported by
`typescript-eslint`](typescript-eslint/typescript-eslint#6934).
@bradzacher bradzacher unpinned this issue Jul 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package New TypeScript Version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants