fix(eslint-plugin): [no-deprecated] support computed member access #10867

azat-io · 2025-02-22T11:46:06Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-deprecated] doesn't report deprecated type index access #10837
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

The rule now correctly detects deprecated properties when they are accessed using computed member expressions (obj['prop']), variables (const x = 'prop'; obj[x]).

typescript-eslint · 2025-02-22T11:46:09Z

Thanks for the PR, @azat-io!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-02-22T11:46:26Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`3507f62`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6821d8bea0011300087e47e9
😎 Deploy Preview	https://deploy-preview-10867--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 87 (🔴 down 12 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2025-02-22T11:47:00Z

View your CI Pipeline Execution ↗ for commit 3507f62.

Command	Status	Duration	Result
`nx run eslint-plugin:test -- --coverage`	✅ Succeeded	6m 24s	View ↗
`nx test eslint-plugin`	✅ Succeeded	6m 2s	View ↗
`nx test eslint-plugin-internal`	✅ Succeeded	2s	View ↗
`nx run types:build`	✅ Succeeded	1s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 1s	View ↗
`nx typecheck ast-spec`	✅ Succeeded	2s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	6s	View ↗
`nx test utils`	✅ Succeeded	3s	View ↗
`Additional runs (26)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-12 11:29:33 UTC

codecov · 2025-02-22T12:01:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (a89d5e3) to head (3507f62).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10867   +/-   ##
=======================================
  Coverage   90.91%   90.92%           
=======================================
  Files         499      499           
  Lines       50808    50841   +33     
  Branches     8369     8380   +11     
=======================================
+ Hits        46194    46227   +33     
  Misses       4599     4599           
  Partials       15       15

Flag	Coverage Δ
unittest	`90.92% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts	`96.96% <100.00%> (+0.33%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

azat-io · 2025-02-24T20:42:21Z

Rebased.

JoshuaKGoldberg

Thanks for getting this started! Codecov is surfacing that several logical branches aren't covered by tests - could you please test them?

JoshuaKGoldberg · 2025-04-07T12:09:53Z

👋 Just checking in @azat-io, do you still have time for this?

azat-io · 2025-04-08T15:07:53Z

Yes, sorry for the delay, I'll be back at the end of the week.

azat-io · 2025-05-05T13:27:14Z

Any feedback?

JoshuaKGoldberg · 2025-05-05T15:45:27Z

Oh I didn't realize this was ready for re-review! We normally wait until the actual Re-Request Review button is pressed. But great, looking now!

JoshuaKGoldberg

LGTM, thanks!

Just a couple of small notes, nothing we can't apply before merging. Only the removal of isStringLiteral() is something I think we really need.

packages/eslint-plugin/src/rules/no-deprecated.ts

@azat-io

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.31.0 | 8.32.1 | | npm | @typescript-eslint/parser | 8.31.0 | 8.32.1 | ## [v8.32.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8321-2025-05-12) ##### 🩹 Fixes - **eslint-plugin:** \[consistent-indexed-object-style] check for indirect circular types in aliased mapped types ([#11177](typescript-eslint/typescript-eslint#11177)) - **eslint-plugin:** \[consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for `TSMappedType` with no type annotation ([#11180](typescript-eslint/typescript-eslint#11180)) - **eslint-plugin:** \[no-deprecated] support computed member access ([#10867](typescript-eslint/typescript-eslint#10867)) - **eslint-plugin:** \[no-unnecessary-type-conversion] shouldn't have fixable property ([#11194](typescript-eslint/typescript-eslint#11194)) ##### ❤️ Thank You - Azat S. [@azat-io](https://github.com/azat-io) - Dima Barabash [@dbarabashh](https://github.com/dbarabashh) - Ronen Amiel You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.32.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8320-2025-05-05) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] add option `allowRethrowing` ([#11075](typescript-eslint/typescript-eslint#11075)) - **eslint-plugin:** \[no-unnecessary-type-conversion] add rule ([#10182](typescript-eslint/typescript-eslint#10182)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] fix parenthesization bug in suggestion ([#11098](typescript-eslint/typescript-eslint#11098)) - **eslint-plugin:** \[unified-signatures] exempt `this` from optional parameter overload check ([#11005](typescript-eslint/typescript-eslint#11005)) - **eslint-plugin:** \[no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary ([#10907](typescript-eslint/typescript-eslint#10907)) ##### ❤️ Thank You - Andy Edwards - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - Sasha Kondrashov - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.31.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8311-2025-04-28) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-condition] downgrade fix to suggestion ([#11081](typescript-eslint/typescript-eslint#11081)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

azat-io force-pushed the fix/no-deprecated-objects branch from ca1fc1f to c715c75 Compare February 24, 2025 20:41

JoshuaKGoldberg requested changes Mar 2, 2025

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Mar 2, 2025

azat-io force-pushed the fix/no-deprecated-objects branch 2 times, most recently from febc81f to 2bc22e8 Compare March 2, 2025 12:27

JoshuaKGoldberg added the stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period label Apr 7, 2025

azat-io force-pushed the fix/no-deprecated-objects branch 4 times, most recently from 05a7916 to f19bc3f Compare April 20, 2025 15:28

JoshuaKGoldberg removed the stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period label Apr 21, 2025

JoshuaKGoldberg self-requested a review May 5, 2025 15:45

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label May 5, 2025

JoshuaKGoldberg previously approved these changes May 5, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-deprecated.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-deprecated.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 5, 2025

azat-io added 3 commits May 5, 2025 19:18

fix(eslint-plugin): [no-deprecated] support computed member access

ca600d7

test(eslint-plugin): [no-deprecated] increase test coverage

a19754f

fix(eslint-plugin): [no-deprecated] add fix by review

8bff4a6

azat-io dismissed JoshuaKGoldberg’s stale review via 8bff4a6 May 5, 2025 16:20

azat-io force-pushed the fix/no-deprecated-objects branch from f19bc3f to 8bff4a6 Compare May 5, 2025 16:20

Merge branch 'main' into fix/no-deprecated-objects

3507f62

JoshuaKGoldberg merged commit 523b3ea into typescript-eslint:main May 12, 2025
56 of 57 checks passed

github-actions bot locked as resolved and limited conversation to collaborators May 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-deprecated] support computed member access #10867

fix(eslint-plugin): [no-deprecated] support computed member access #10867

azat-io commented Feb 22, 2025

Uh oh!

typescript-eslint bot commented Feb 22, 2025

Uh oh!

netlify bot commented Feb 22, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Feb 22, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 22, 2025 •

edited

Loading

Uh oh!

azat-io commented Feb 24, 2025

Uh oh!

JoshuaKGoldberg left a comment •

edited

Loading

Uh oh!

JoshuaKGoldberg commented Apr 7, 2025

Uh oh!

azat-io commented Apr 8, 2025

Uh oh!

azat-io commented May 5, 2025

Uh oh!

JoshuaKGoldberg commented May 5, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(eslint-plugin): [no-deprecated] support computed member access #10867

fix(eslint-plugin): [no-deprecated] support computed member access #10867

Conversation

azat-io commented Feb 22, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Feb 22, 2025

Uh oh!

netlify bot commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

azat-io commented Feb 24, 2025

Uh oh!

JoshuaKGoldberg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg commented Apr 7, 2025

Uh oh!

azat-io commented Apr 8, 2025

Uh oh!

azat-io commented May 5, 2025

Uh oh!

JoshuaKGoldberg commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Feb 22, 2025 •

edited

Loading

nx-cloud bot commented Feb 22, 2025 •

edited

Loading

codecov bot commented Feb 22, 2025 •

edited

Loading

JoshuaKGoldberg left a comment •

edited

Loading

JoshuaKGoldberg commented May 5, 2025 •

edited

Loading