feat(eslint-plugin): [restrict-template-expressions] add option allow any
#1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @itowlson! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
bradzacher
changed the title
any
bradzacher
added
the
enhancement: plugin rule option
Codecov Report
@@ Coverage Diff @@
## master #1762 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 162 162
Lines 7487 7490 +3
Branches 2146 2148 +2
=======================================
+ Hits 7074 7077 +3
Misses 178 178
Partials 235 235
|
This was referenced Apr 19, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1660.
Sometimes it can be useful to allow the
anytype in template expressions. Although a typescript-eslint user will usually prefer the stronger checking, there are times when the weaker checking is useful if the author is confident the value will stringise sanely, for example in codebases with significant legacy, or where there is a lot of handling of untyped values, or in scenarios such as thecatchcase outlined in #1660.This PR provides an option not to warn if an
anyvalue is dumped in a template expression. The option is off by default because, as mentioned in the issue, the goal of the rule is "to make sure you're not doing something that might dump garbage into your template strings," and nothing is more able to dump garbage thanany...!