fix(typescript-estree): handle BigInt with _ numeric separator
#2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @fisker! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
fisker
changed the title
numberic separatorBigInt with numberic separator
fisker
force-pushed
the
numberic-separator-bigint
branch
from
9fd8390 to
c5a48b1
Compare
fisker
force-pushed
the
numberic-separator-bigint
branch
from
c5a48b1 to
39e5748
Compare
Codecov Report
@@ Coverage Diff @@
## master #2067 +/- ##
=======================================
Coverage 93.40% 93.40%
=======================================
Files 171 171
Lines 7745 7745
Branches 2210 2210
=======================================
Hits 7234 7234
Misses 246 246
Partials 265 265
|
bradzacher
approved these changes
May 22, 2020
bradzacher
changed the title
BigInt with numberic separatorBigInt with _ numeric separator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
BigIntwithnumberic separatorparsing.The estree spec only said
nshould not include inbigint,so I guess._should perserveUpdate: The spec says
bigint property is the string representation of the BigInt value, and we are usingString(BigInt('123'))for1_2_3n, it doesn't includes_, so it should not include_.