feat(eslint-plugin): [naming-convention] improve performance by removing unnecessary selectors

[bradzacher]

Part of my performance investigations on large codebases.
Right now we always register every single node selector in naming-convention, even if the user's config will never match that selector.

This is bad because eslint registers, parses and evaluates these selectors. All totalled these selectors combined pretty-well add up to every single identifier in the codebase!
Which is a lot of processing that's not required!

It's a simple change that can save 10s of seconds on codebases that don't use the default config selector.

[typescript-eslint]

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 84767a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test scope-manager
• Node 18 - nx test type-utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test typescript-estree
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test parser
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test typescript-estree --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test parser --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-tslint
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test ast-spec
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-internal
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	84767a5
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63d979eebe0e7e00081d944c
😎 Deploy Preview	https://deploy-preview-6376--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #6376 (3a7aed3) into main (5bf7f7f) will increase coverage by 0.12%.
The diff coverage is 95.72%.

❗ Current head 3a7aed3 differs from pull request most recent head 84767a5. Consider uploading reports for the commit 84767a5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6376      +/-   ##
==========================================
+ Coverage   91.38%   91.51%   +0.12%     
==========================================
  Files         368      368              
  Lines       12608    12584      -24     
  Branches     3713     3704       -9     
==========================================
- Hits        11522    11516       -6     
+ Misses        770      752      -18     
  Partials      316      316              

Flag	Coverage Δ
unittest	91.51% <95.72%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts	89.11% <95.72%> (+7.09%)	⬆️

[JoshuaKGoldberg]

Love it!! ❤️‍🔥